FrostCo / AdvancedProfanityFilter

A browser extension to filter profanity from webpages
GNU General Public License v3.0
159 stars 26 forks source link

Audio muting doesn’t work on iphone #510

Open bee911 opened 10 months ago

bee911 commented 10 months ago

Hello, I have Apf installed on my iPhone and it works perfectly for text but never works for video sites. I also have same on my laptop and it works perfectly text and video sites, and I have the same config loaded on both iPhone and iPad windows. On iPhone I am using from safari and it shows extension loaded and all same config as my laptop. Would you be able to help fix this issue? Thank you

bee911 commented 10 months ago

Hello, just checking back as haven’t seen update

richardfrost commented 10 months ago

Hi @bee911, I'm sorry for the slow response on this. I'd love to be able to help you get it working. With audio muting for iOS devices APF tries to do its best, but there are a lot of variables involved with it, so I find it is usually easiest to pick a specific site to make sure it is working there first. Would you be able to test with YouTube? In my experience it is usually the easiest to support, and is a great place to start. It might be easiest to just pick a video that has captions and then temporarily add a word to the filter test with that is included in those captions (for example: "hello", or "food").

Also, websites can vary based on the country you are accessing it from. Where are you watching from?

bee911 commented 10 months ago

Thank you Richard. I am in USA and using the custom filter code you did for me last year for Vimeo. I simply imported same config from my windows edge browser extension to the iPhone safari extension. I can see all the same settings on iPhone they are windows browser. but when I go to my same investment site on Vimeo it never mutes even when I turn on cc. The cc just shows up which doesn’t on windows as apf just mutes and only shows cc when it mutes something.

Do you have a YouTube video can try as I cannot find one where I can enable cc like I can vimeo?

Your apf on iPhone works perfectly for websites with just text as all my custom words are always blocked. It is just the audio that doesn’t stop

Thank you as always

richardfrost commented 9 months ago

@bee911 Sorry for another delayed response on this. I finally had a chance to test this with an iPad, and it seemed to work on the video I tested with: https://vimeo.com/358296408

Could you try it on that video, and temporarily add the word internet to your word filter list? That should trigger in the first couple seconds (make sure to enable CC). If that works, but you have other video(s) that don't, could you share a link to one and I'll take a look? Thanks!

One other quick thought, which mute method are you using on your iPhone/iPad? Unfortunately they aren't all compatible with each other. For the iPad and iPhone I recommend using the "Video mute" method.

bee911 commented 9 months ago

@richardfrost the vimeo url doesn't work either. once i enable CC in vimeo, all CC is always shown. APF is config'd to only show CC when muted like my desktop does.

i have tried all the mute options, and the config on my ipad/iphone is the same as my desktop as i simply exported config to file using your backup method on desktop and imported on iphone. desktop works perfectly but iphone and ipad never mute video/audio. however, ipad/iphone have always worked with text on a website without issue and blanks out bad words on websites.

unfortunately i cannot provide you site urls as you did customization for me last year and those sites require logon. here is that custom code:

{ "player.vimeo.com": [ { "displaySelector": "div.vp-captions", "mode": "watcher", "subtitleSelector": "div.vp-captions span.vp-captions-line" } ], "vimeo.com": [ { "displaySelector": "div.vp-captions", "mode": "watcher", "subtitleSelector": "div.vp-captions span.vp-captions-line" } ], "web.microsoftstream.com": [ { "displaySelector": "", "iframe": false, "mode": "watcher", "subtitleSelector": "div.video-player-container div.vjs-text-track-display > div > div > div" } ] }

finally, here is image of audio tab config. it is same on iphone/ipad and desktop. on iphone i also tried mute video option as you requested but it doesn't work either. image

thank you for help!