FrostCo / AdvancedProfanityFilter

A browser extension to filter profanity from webpages
GNU General Public License v3.0
159 stars 26 forks source link

Audio Muting for Nlziet #523

Closed TheodorusL closed 6 months ago

TheodorusL commented 8 months ago

:movie_camera: The Site

app.nlziet.nl

:speech_balloon: Subtitle Element/Node

<section class="VTn6M">
  <div class="FxxsA">
    <div>
      <span>
        <span class="white" style="color:white;">
          En hij is er inmiddels achter
        </span>
        <br>
        <span class="white" style="color:white;">
          waar je woont.
        </span>
      </span>
    </div>
  </div>
</section>

:pencil: Additional notes

The active subtitle on this frame contains two lines:

En hij is er inmiddels achter waar je woont.

I hope you can help me to add NLZiet as an Audio Muting Site. I've tried to add it myself, but could not get it working. Thank you very much for helping me!

richardfrost commented 8 months ago

Hi @TheodorusL, thanks for reaching out about this. Unfortunately I haven't been able to access a video on the site without a subscription, and because I'm in the United States it doesn't seem like I can setup an account.

If you're willing to help me gather some information it might be possible to add support for this site. If you'd like to help out, please send an email to support @ frostco.dev (without the spaces).

If not, that's okay. I'll see if I can figure anything else out.

TheodorusL commented 8 months ago

Hi Richard,

Thanks for wanting to help me out.

I used this series for testing: https://app.nlziet.nl/vod/jBEBQUkg_0i3rfaasyIDVw The first subtitles in this episode are shown after a few seconds. I used the word 'woont' as trigger to test.

Thanks again for helping me out!

With kind regards,

Theodorus

------ Oorspronkelijke bericht ------ Van "Richard Frost" @.**@.>> Aan "FrostCo/AdvancedProfanityFilter" @.**@.>> CC "Theodorus" @.**@.>>; "Mention" @.**@.>> Datum 10-11-2023 01:11:41 Onderwerp Re: [FrostCo/AdvancedProfanityFilter] Custom Audio Site (Issue #523)

Hi @TheodorusLhttps://github.com/TheodorusL, thanks for reaching out about this. Unfortunately I haven't been able to access a video on the site without a subscription, and because I'm in the United States it doesn't seem like I can setup an account.

If you're willing to help me gather some information it might be possible to add support for this site. If you'd like to help out, please send an email to support @ frostco.dev (without the spaces).

If not, that's okay. I'll see if I can figure anything else out.

— Reply to this email directly, view it on GitHubhttps://github.com/FrostCo/AdvancedProfanityFilter/issues/523#issuecomment-1804872832, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BD3CV4OHKGR4HZX4NYOZ5ETYDVWL3AVCNFSM6AAAAAA7EPUMDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMBUHA3TEOBTGI. You are receiving this because you were mentioned.Message ID: @.***>

richardfrost commented 7 months ago

Hi @TheodorusL, sorry for the delay. I've have other things I needed to focus on for a bit. Thanks for being willing to help out. Credentials can't be shared on Github, so could you please send them to the email address mentioned in my last post?

richardfrost commented 7 months ago

@TheodorusL I'm so sorry this has taken me so long. I am usually quite a bit faster than this, but have just been really busy these last few weeks.

Would you be able to test this config?

{
  "app.nlziet.nl": [
    {
      "className": "VTn6M",
      "displaySelector": "section.VTn6M",
      "mode": "element",
      "subtitleSelector": "span",
      "tagName": "SECTION",
      "videoSelector": "div.bitmovinplayer-container video"
    },{
      "displaySelector": "section.VTn6M",
      "mode": "elementChild",
      "parentSelector": "section.VTn6M",
      "tagName": "SPAN",
      "videoSelector": "div.bitmovinplayer-container video"
    }
  ]
}

To use this config, paste it into the Custom Sites area (Options page > Audio tab) and click the blue "SAVE" button underneath it. Then, make sure to refresh the tab for the video site (if you have it open still) and it will load this new configuration.

TheodorusL commented 7 months ago

Thank you very much. I did some testing, and it works great! Thank you very, very much!

With kind regards,

Theodorus

------ Oorspronkelijke bericht ------ Van "Richard Frost" @.**@.>> Aan "FrostCo/AdvancedProfanityFilter" @.**@.>> CC "Theodorus" @.**@.>>; "Mention" @.**@.>> Datum 8-12-2023 01:51:32 Onderwerp Re: [FrostCo/AdvancedProfanityFilter] Audio Muting for Nlziet (Issue #523)

@TheodorusLhttps://github.com/TheodorusL I'm so sorry this has taken me so long. I am usually quite a bit faster than this, but have just been really busy these last few weeks.

Would you be able to test this config?

{ "app.nlziet.nl": [ {

"className": "VTn6M", "displaySelector": "section.VTn6M", "mode": "element", "subtitleSelector": "span", "tagName": "SECTION", "videoSelector": "div.bitmovinplayer-container video" },{ "displaySelector": "section.VTn6M", "mode": "elementChild", "parentSelector": "section.VTn6M", "tagName": "SPAN", "videoSelector": "div.bitmovinplayer-container video" } ] }

To use this config, paste it into the Custom Sites area (Options page > Audio tab) and click the blue "SAVE" button underneath it. Then, make sure to refresh the tab for the video site (if you have it open still) and it will load this new configuration.

— Reply to this email directly, view it on GitHubhttps://github.com/FrostCo/AdvancedProfanityFilter/issues/523#issuecomment-1846331128, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BD3CV4MH5H2A4OK2SOXZYP3YIJQBJAVCNFSM6AAAAAA7EPUMDWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBWGMZTCMJSHA. You are receiving this because you were mentioned.Message ID: @.***>

richardfrost commented 6 months ago

You're very welcome @TheodorusL! Thanks for being willing to help make it possible. Enjoy!

richardfrost commented 6 months ago

This has been included in version 3.3.0. Feel free to comment here if you have any feedback for this update.