FrostCo / AdvancedProfanityFilter

A browser extension to filter profanity from webpages
GNU General Public License v3.0
164 stars 27 forks source link

redbox.com captions are censored but audio isn't #557

Closed bdc0der closed 3 months ago

bdc0der commented 5 months ago

:bug: Description

On redbox.com., the captions will be censored but the audio isn't.

:twisted_rightwards_arrows: Steps To Reproduce

  1. Go to redbox.com
  2. Click on any movie (I chose the lost city, time stamp 4:00)
  3. Captions mute but audio won't

    :heavy_check_mark: Expected behavior

I expected the audio and captions to mute/censor when a filtered word showed up in the captions

:camera: Screenshots

N/A

:computer: Details

:pencil: Additional context

When the bad word appears in the captions, the extension turns green and says "muting active", so the extension can detect the word, but for whatever reason, is unable to filter the audio.

I have also tried using a brand new chrome profile and extension config (I still turn on the mute audio on supported sites and add additional words)

richardfrost commented 5 months ago

Hi @bdc0der, thanks for reporting the issue. It looks like they may have updated their site which may be causing this issue. Can you give this custom config a try?

{
  "www.redbox.com": [
    {
      "displaySelector": "div.rb-text-container",
      "findChildText": true,
      "mode": "elementChild",
      "note": "on demand",
      "parentSelector": "div.rb-text-container",
      "tagName": "DIV"
    },
    {
      "className": "cc-text-container",
      "mode": "element",
      "note": "free live tv",
      "subtitleSelector": "div.hlsjs-cue-container p.hsljs-cue",
      "tagName": "DIV"
    },
    {
      "displaySelector": "div.rb-text-container",
      "findChildText": true,
      "mode": "elementChild",
      "note": "on demand",
      "parentSelector": "div.rb-text-container",
      "tagName": "SPAN"
    }
  ]
}

To use this config, paste it into the Custom Sites area (Options page > Audio tab) and click the blue "SAVE" button underneath it. Then, make sure to refresh the tab for the video site (if you have it open still) and it will load this new configuration.

For best results, make sure to remove any custom config used for testing like this once it has been included in the official update.

bdc0der commented 5 months ago

This new config appears to be working, thanks for the help!

richardfrost commented 3 months ago

This has been included in version 3.5.1. Thanks again for reporting the issue, and also getting back to me about the fix.