Frostshake / TrinityCoreClassic

Frostshake/TrinityCoreClassic - vanilla_classic = 1.14.0.40618
https://github.com/Frostshake/TrinityCoreClassic/tree/vanilla_classic
GNU General Public License v2.0
5 stars 2 forks source link

Implement Talents #4

Open Frostshake opened 5 months ago

Frostshake commented 5 months ago

some spells show incorrect power usage e.g searing pain has weird int overflow when learning 'cataclysm' talent. need to check SMSG_SET_PCT_SPELL_MODIFIER , SMSG_SET_FLAT_SPELL_MODIFIER, and similar looks to be caused by trinity sending the modifier as a float, while hermes and vmangos use int32, changing to use int32 does partly solve the issue, however the tooltip/resolved value still not accurate.