search

FrostyCoolSlug / goxlr-utility-streamdeck

A StreamDeck Plugin for use with the GoXLR Utility
MIT License
41 stars 9 forks source link

added long-press #5

Closed KindarConrath closed 3 months ago

KindarConrath commented 3 months ago

Description

Added a .5 second "long press" to make the mute behave like the mute button on the goxlr

KindarConrath commented 3 months ago

I do have one weird behaviour,

press results in mute -> Icon bright unmute -> Icon dark

holding results in mute -> bright until release then dark unmute -> dark until release then bright

FrostyCoolSlug commented 3 months ago

I do have one weird behaviour,

press results in mute -> Icon bright unmute -> Icon dark

holding results in mute -> bright until release then dark unmute -> dark until release then bright

I'm guessing the code in doMute isn't handling the different behaviours properly, although I don't see anything particularly wrong with it.. I'll need to pop over to Windows to check (I'll probably find some time to do that over the weekend).

FrostyCoolSlug commented 3 months ago

One annoyance with the Stream Deck that I do remember, is that it automatically switches between the lighting states as soon as the button is pressed, the only way to adjust that programmatically is by forcing a new state through, I'm wondering if the hold / release behaviour is getting a little fighty with how the Deck manages lighting and the action forcefully setting a state while the button is currently held (with the release flicking it to the opposite state)...

KindarConrath commented 3 months ago

that makes sense, I think I can deal with that then

KindarConrath commented 3 months ago

fixed it, didn't realize before that the SD API sets the state as well

FrostyCoolSlug commented 3 months ago

All looks good, thanks!