FrostyX / fedora-review-service

Fedora package reviews CI
9 stars 1 forks source link

Provide information how to get sponsored #18

Closed FrostyX closed 1 year ago

FrostyX commented 1 year ago

An action should be triggered when a ticket receives the fedora-review+ flag. If it was given by a packager who is not a sponsor himself, and no other sponsor is currently assigned to the bug, we should post a comment to the ticket. For example:

Since this would be your first Fedora package, you will need to get
sponsored into the `packager' group before this package can be
accepted.

It will be a sponsor's responsibility to guide you through the processes that
you will do, and the tools that you will need as a package maintainer. A sponsor
will also be there to answer your packaging-related questions, or to
help you find somebody who knows the answers.

To find yourself a sponsor, please follow these instructions:
https://docs.fedoraproject.org/en-US/package-maintainers/How_to_Get_Sponsored_into_the_Packager_Group/#how_to_find_a_sponsor

(A quick draft, it'll be improved when implementing this feature)

Edit: Or we can create an issue in the https://pagure.io/packager-sponsors/issues tracker automatically, and then just let the contributor know about it.

gotmax23 commented 1 year ago

Can you add a way to opt out of a this on a per ticket basis? Perhaps the review service could skip this step if e.g. [skip packager-sponsors ticket] is in the bug's Whiteboard field. A sponsor may have already agreed to sponsor someone but isn't the one reviewing the package. In this case, creating another ticket would be confusing to the people involved. Otherwise, I think this is a great idea!

sanjayankur31 commented 1 year ago

Additional note: we also need to update the package maintainer docs to note this when it has been implemented

are two pages I can think of off the top of my head.

Thanks again for this, it's a great idea!

FrostyX commented 1 year ago

I just pushed cdd6f4d which fixes this issue and deployed it to production. A few notes: