search

FrostyX / fedora-review-service

Fedora package reviews CI
7 stars 1 forks source link

Provide option to opt out of fedora-review-service #24

Open penguinpee opened 1 year ago

penguinpee commented 1 year ago

I already build all my packages I submit for review in Copr, precisely because I find the the fedora-review option very handy for detecting issues before submitting the package for review.

Therefore, it feels redundant that fedora-review-service does the same again. An option to disable fedora-review-service would allow users to opt out. Something similar to explicitly triggering it like [fedora-review-service-skip] or [fedora-review-service-opt-out] added in a comment would be most convenient. Maybe a specific string in Whiteboard or Personal tags could also work. That remains unchanged when submitting updates throughout the review process.

Another use case where one may want to opt out is when a package needs bootstrapping. I encountered that when reviewing some low level python mingw packages a while ago.

ppfeister commented 4 months ago

+1

Came to the repo to make this very suggestion. As an added use case (my use case)...

My SRPM link died and needed replacing. Simple minor update (no email) with the new link, no other changes made and no build necessary.

Would be nice to have this option for minor updates like this, so the build doesn't trigger and send emails to everyone or add noise to the message history.