FrostyX / fedora-review-service

Fedora package reviews CI
7 stars 1 forks source link

review templates not being generated in copr #41

Open juhp opened 7 months ago

juhp commented 7 months ago

eg

$ curl -I https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2260853-ghc-language-c99-util/fedora-rawhide-x86_64/07099420-ghc-language-c99-util/fedora-review/review.txt
HTTP/2 200 
content-type: text/plain
content-length: 0
etag: "1963244301"
last-modified: Sun, 03 Mar 2024 18:45:43 GMT
:

or is this some kind of caching/cloudfront issue?

As I see it this has actually been happening for some weeks now perhaps? So it is a little disconcerting that it is still happening? Though I know it is not an official service. :-) :pray:

FrostyX commented 7 months ago

Thank you for the report @juhp.

So it is a little disconcerting that it is still happening/unnoticed?

Don't worry, it wasn't unnoticed. It wasn't easy to investigate and fix :-/.

We had reports across all involved upstreams

The bug is in the fedora-review tool, Fedora Review Service and Copr are innocent. I am proposing the fix here

https://pagure.io/FedoraReview/pull-request/513

@michel-slm promised to review the changes and do a new release this week if it works well.

But I agree with you, it is a bad look (for the service) that it doesn't work and wasn't fixed yet.

juhp commented 7 months ago

Okay sorry, thank you for the detailed explanation - appreciate all the efforts and your dedication

FrostyX commented 7 months ago

Okay sorry

Np, I am glad you reported the issue. I will keep it open, so we have some ticket for Fedora Review Service as well.