search

FrostyX / tracer

Tracer finds outdated running applications in your system
GNU General Public License v2.0
81 stars 24 forks source link

CentOS uses DNF #165

Closed marusak closed 3 years ago

marusak commented 3 years ago

Without this patch tracer always returns empty result as by default dnf is being used on centos and not yum.

FrostyX commented 3 years ago

Hello, thank you for the PR, looks good.

I see one potential problem. AFAIK Centos 7 still uses Yum, so we need to make sure this change doesn't traceback there.

marusak commented 3 years ago

Right, I can do that. I just wonder if centos-7 ships tracer (not to my knowledge) thus it would be no-op anyway.

FrostyX commented 3 years ago

I just wonder if centos-7 ships tracer (not to my knowledge)

I build tracer for EPEL 7 https://src.fedoraproject.org/rpms/tracer/commits/epel7

marusak commented 3 years ago

Fair enough, I've pushed updated version. I am not super happy about it but I could not think of less intrusive change. And this one should be easy to get rid of once centos-7 won't be a thing anymore.

FrostyX commented 3 years ago

Thank you very much for the PR @marusak, I just tested and it works for me.

+1

I am going to wait a couple of days in case somebody else wishes to review and I will merge and make a new release by the end of this week. Is it okay with you?