search

FrostyX / tracer

Tracer finds outdated running applications in your system
GNU General Public License v2.0
82 stars 24 forks source link

python3-setuptools #183

Closed sbernhard closed 2 years ago

sbernhard commented 2 years ago

Hi,

I wonder, why the python3-setuptools is set as a dependency in the tracer.spec file? I thought, that the setuptools are used to build and distribute python stuff.

Is the setuptools really necessary or can we remove the "Require: python3-setuptools" (and the python2-setupools for pyton2).

Best regards, Bernhard

CC @jturel

FrostyX commented 2 years ago

Hello @sbernhard and @jturel, the python3-setuptools dependency was added in https://github.com/frostyx/tracer/commit/15ad905858b7942dfce9a551952aa934b18591c5 in order to compare version numbers.

We can use some other comparison function if you wish to drop the setuptools dependency.

jturel commented 2 years ago

Looks like that code has since been refactored and there's not a runtime dependency on setuptools!

sbernhard commented 2 years ago

What do you think about using "python packaging"? See documentation https://packaging.pypa.io/en/latest/version.html.

Example: https://thewebdev.info/2021/10/24/how-to-compare-version-numbers-in-python/

Details about the 'python3-packaging' rpm package in centos: https://centos.pkgs.org/8/centos-powertools-x86_64/python3-packaging-16.8-9.el8.noarch.rpm.html

FrostyX commented 2 years ago

Looks like that code has since been refactored and there's not a runtime dependency on setuptools!

Ah, I missed that, thank you @jturel. Please see PR #185