rework lumber redistribute behavior

Frotty / ForestDef

Forest Defense - a wc3 funmap

6 stars 4 forks source link

rework lumber redistribute behavior #13

Closed Cokemonkey11 closed 5 years ago

Cokemonkey11 commented 5 years ago

Concerns (please read):

It is now possible for this event to be quite spammy, if none of the players spend their lumber
I've not tested this for correctness
This will only work nicely if we commit to using LinkedList<>.addLumber(int, bool) in the general case

Frotty commented 5 years ago

What did you even change?

Cokemonkey11 commented 5 years ago

@Frotty

What did you even change?

All addLumber events now perform a maybeRedistribute operation

Frotty commented 5 years ago

reason being?

Cokemonkey11 commented 5 years ago

@Frotty

reason being?

Frotty just adds to predictability I think is the main benefit

Also DRYed it up a bit but that's kind of irrelevant

What don't you like about it?

Frotty commented 5 years ago

thanks 👍 I expect to make modifications after playing tho