search

Frotty / Frentity

Hierarchical Entity Framework
Apache License 2.0
11 stars 6 forks source link

wurst compile errors on importing TextTagEntity from frentity/entity/TextTagEntity #1

Closed Krypt0n closed 6 years ago

Krypt0n commented 6 years ago

getting serveral errors on importing TextTagEntity see below: frentity_compile_error

jenkins build seems also to be failed aswell: http://peeeq.de/hudson/job/Frentity/552/console

Krypt0n commented 6 years ago

fix is needed because of TerrainUtils has been updated (link to commit): replace in PhysicsEntity.wurst line 24: terrainZ = getTerrainZ(pos.x, pos.y) with: terrainZ = pos.getTerrainZ()

replace in Entity.wurst line 100: if pos.z > (DYNAMIC_Z ? getTerrainZ(pos.toVec2()) : 0) with: if pos.z > (DYNAMIC_Z ? pos.getTerrainZ() : 0)

... etc.

temporary fixxed in: https://github.com/Krypt0n/Frentity ----- commmit_link

Frotty commented 6 years ago

Thanks for the report. The standard library update wasn't supposed to be a breaking change. I have pushed stdlib fixes and will update this repo soon.

Krypt0n commented 6 years ago

i also needed to rename the EventListener see this commit

Frotty commented 6 years ago

Oh, must have been a mistake then. (the build pipeline is succeeding now) However yes, Event from Frentity will be moved to stdlib as ClosureEvents very soon (this month) with some additions. Then I will also do some cleanup on Frentity. Thanks for the feedback