search

Frozen-Developers / android-cache-cleaner

[DEPRECATED] Open-source cache cleaner for Android
MIT License
162 stars 68 forks source link

Added Portuguese translation #13

Closed smarquespt closed 9 years ago

lubo commented 9 years ago

Hello, @smarquespt. Thank you for your contribution. Please, remove all the strings marked with translatable="false" because these are not meant to be reused. Otherwise, your commit seems good and I will merge it as soon as you fulfill my request.

smarquespt commented 9 years ago

@Kuci

Please check if it´s ok for you.

Regards

lubo commented 9 years ago

@smarquespt, you did not remove trailing newlines after the strings. Because we want to keep the sources clean, please, remove these unnecessary newlines.

lubo commented 9 years ago

Great. Now rebase all commits into a single one with the message 'Add Portuguese translation' and it is good to go.

smarquespt commented 9 years ago

I´m trying to but I can´t. Can you tell me the commands?

lubo commented 9 years ago

In this case I would just soft reset to the first commit and then amend and force push.

lubo commented 9 years ago

Please, use 'Add Portuguese translation' as the commit message.

lubo commented 9 years ago

Well, I had some time so I have done it myself. Except changing the commit message I had to remove several whitespaces which I had not noticed before.

Once again, thank you for your contribution.