Closed 2No2Name closed 2 weeks ago
Odd. I play with Lithium and I haven’t had this happen since I switched that line to the blocking version. Using the other execute method results in this issue, however.
Maybe I misattributed it, which other methods do you mean?
Maybe I misattributed it, which other methods do you mean?
There’s a .execute and a .executeBlocking method, and as far as I’m aware the blocking variant solves that issue. There’s always a chance it doesn’t for everyone, but I’ve genuinely never had this happen in my months of playing- even alongside Lithium which I always use on my server.
I think I've gotten to the bottom of the cause of this.
Using modernfix's thread dump you can see that frozenlib's FadingDiskTagFeature
is parked in the chunk gen thread "Worker-Main-5"
Full thread dump: https://mclo.gs/TDU0TQ7
So I wrote a small mixin to just skip the disk generation (cancellable inject at head of place (moj)
/generate (yarn)
) and re-opened the same world where the deadlock happened initially and it did not hang or deadlock.
Some notes:
Rip
If anyone knows how to generate features similarly to structures (it saves, and generates per-chunk instead of generating all at once) that would be awesome and solve the issue completely
@Treetrain1 maybe you could try doing this
Fixed by simply removing this, and limiting features to a max radius of 15.
This line seems to cause the chunk generation to deadlock. However, lithium is also in that stacktrace, so we are not sure whether it is really only caused by your mod.
https://github.com/FrozenBlock/FrozenLib/blob/29e4e68692855b8d5a43348892771b27fc316503/src/main/java/net/frozenblock/lib/worldgen/feature/api/features/FadingDiskTagFeature.java#L116
Crash report: https://mclo.gs/e5zFnhU
(First reported to https://github.com/CaffeineMC/lithium-fabric/issues/493)