FrozenBlock / WilderWild

A Minecraft mod that overhauls the Wild Update 
https://modrinth.com/mod/wilder-wild
GNU General Public License v3.0
85 stars 24 forks source link

Optimized hollowed log model with compatibility and proper culling #379

Closed Soulfate24 closed 4 months ago

Soulfate24 commented 4 months ago

Hi! I've optimized the "hollowed" and "stripped hollowed" log models by using 8 blocks, vanilla textures (excepted for Baobab, Cypress and Palm) and proper culling so it's performance friendly. "Hollowed" textures are not used anymore (only original "log" and "stripped" ones are necessary). LINK (1.20.4 version): https://drive.google.com/drive/folders/1xGpq_7k6lbDsQSxXiSVVdcsZD3FwRZKk wilderwild_optimized_hollow

With love, Soulfate

AViewFromTheTop commented 4 months ago

Have you checked how this looks in-game? The main issue is that for whatever reason, it causes some parts of the texture to be misaligned in-game. No clue why, and is absolutely a vanilla issue. If you’ve gotten that to somehow not happen, I’ll gladly implement this.

Soulfate24 commented 4 months ago

About gap issues, you have the mod "model gap fix" that fixes any misaligned sides (while the rendering is perfect in the editor). It's a universal fix and it works with this kind of custom models ;) I've honestly forgotten about this issue because I always have "model gap fix" installed.

It's not exactly the same model because I'm working on a resourcepack these days (and that's why I'm proposing the cubic model here), but the base is the same: example

AViewFromTheTop commented 4 months ago

I would prefer if a Vanilla solution were introduced instead, as I personally prefer the mod to work with strictly just Fabric API and nothing else out of the box.

Soulfate24 commented 4 months ago

I understand, thank you for your time ;) I'm going back to my resourcepack :P

Soulfate24 commented 4 months ago

Hi, It's me again. I've ran the game with Quilt, Wilder Wild and my log resources only. There is no issue ;) test

AViewFromTheTop commented 4 months ago

I'll give it a shot, however I still expect this issue to happen. It's been very subtle but noticeable once you look in the right place.

AViewFromTheTop commented 4 months ago

wtf the issue doesnt happen????? @Treetrain1 this is crazy