FrozenIronSoftware / Twitched

Unofficial Twitch app for the Roku
https://www.twitched.org
Other
29 stars 8 forks source link

Cannot f #44

Closed ThAlEdison closed 5 years ago

ThAlEdison commented 5 years ago

Description

When trying to fast forward during a very long stream it's not possible after the 24h mark.

Steps to Reproduce

  1. Find a video longer than 24 hours https://m.twitch.tv/videos/365966431
  2. Fast forward or move the time forward.
  3. Initially the time remaining will show an incorrect value (it will be off by 24 hours). Once the time remaining hits 0h, it'll wrap around to 24 hours.
  4. Once you reach the 24h played mark it'll wrap to 0h and no longer be able to be increased.
  5. It looks like there may have been a programming assumption that there are only 24 hours (maybe due to some conversion from a time type) and once it's more than that on the played side it just returns 0 hours, and can't increase.
  6. This does not affect normal playing from that point, just fast forward.

...

Expected behavior: Fast forward stops working once you hit 24 hours in a video

Actual behavior: Fast forward should work for the whole video

Roku Model: Roku TV 7103X TCL 55P605

Roku Firmware Version: 8.2.0 build 4167-30

Twitched Version: 1.7

Additional Information

The app doesn't seem to have a way to check the version. I had to look in the roku channel store.