search

FrozenPandaz / ng-universal-demo

171 stars 54 forks source link

fix(server-transfer): Fix issue with setting doctype on index.html #9

Closed joaogarin closed 7 years ago

joaogarin commented 7 years ago

When setting the DOCTYPE property of the index.html the head becomes the second element in the DOM. I think this might be a common situation for people so thought maybe would be useful to throw this in here.

Cheers;)

Owain94 commented 7 years ago

@angularClass their solution is more elegant imo

https://github.com/joaogarin/ng-universal-demo/pull/1

joaogarin commented 7 years ago

Right its definitely more broad and will apply better in all cases..I like the simplicity for a starter app though I must say. its up to @FrozenPandaz ;) great that you brought it up I didn't notice this in their repo!

FrozenPandaz commented 7 years ago

Closed by https://github.com/FrozenPandaz/ng-universal-demo/commit/d66b3f707c7b2cf9ea9ace4b2f8fc0fb4da1232c