search

Frozenfire92 / Pages2Repo

A chrome extension to open a repository from a GitHub page
https://chrome.google.com/webstore/detail/pages2repo/afnogakjnebbgcbjkgmhaccljfejeflh
The Unlicense
38 stars 11 forks source link

Stayed signed #12

Closed Johann-S closed 9 years ago

Johann-S commented 9 years ago

When I found a page with a github repo I always have to sign up if the token as expired.

Why not using a token added in https://github.com/settings/tokens to stay signed up ?

Frozenfire92 commented 9 years ago

This is a great idea, the only issue I foresee is if a user doesn't enable the right permissions, however where the sign in page is now putting that in as a screenshot could alleviate this.

I haven't had to sign in multiple times yet ( #6 ), do you by chance know how long the tokens are valid for? I wasn't able to find this in the documentation

Johann-S commented 9 years ago

No I'm not sure about how long a token expire but I've to sign in once a day.

I know it's possible to open a page to add a token with the correct permission pre selected. It's already done by Github Notifier (https://github.com/sindresorhus/github-notifier-chrome)

Done at this line : https://github.com/sindresorhus/github-notifier-chrome/blob/master/extension/options.html#L56

Frozenfire92 commented 9 years ago

Ok cool,

I noticed you forked it, if you plan on working on this let me know, if not I will have time to this weekend :)

Johann-S commented 9 years ago

I'll try but it's the first time I work on a chrome extension so I'm not sure to do it very well

Johann-S commented 9 years ago

I don't know what permissions are needed, to get information about a repository. Do you which one I have to pre select for the user ?

edit personal access token - google chrome

Frozenfire92 commented 9 years ago

The scope as is is blank, so I would try no permissions first to match that. If that didn't work I would guess public_repo. Let me know how it goes, will have a chance to look at it tomorrow

On Fri, Jun 12, 2015, 6:47 PM Johann notifications@github.com wrote:

I don't know what permissions are needed [image: edit personal access token - google chrome] https://cloud.githubusercontent.com/assets/1689750/8140598/5160003a-115d-11e5-88a4-166a62d75b62.jpg

— Reply to this email directly or view it on GitHub https://github.com/Frozenfire92/Pages2Repo/issues/12#issuecomment-111626887 .

Frozenfire92 commented 9 years ago

I've implemented this, looking into #9 then will release a new version later today. Thanks for the feedback / idea!

Frozenfire92 commented 9 years ago

It is published, could take an hour before the chrome webstore updates. Thanks!

Johann-S commented 9 years ago

Nice work ! Sorry I hadn't time this weekend to work on it.

Do you have interest about using GruntJS with JSCS and using Travis for you futur release ?

Frozenfire92 commented 9 years ago

I've implemented Gruntjs for the release in #9 I don't think I will be implementing Travis as I don't really think there is a good way to test extensions from the command line

Johann-S commented 9 years ago

Sure but you can add JSCS to your GruntJS to check for each contribution the contributor respect your code style

Johann-S commented 9 years ago

It works very well thank you !