Frozenlock / bacure

Clojure wrapper for BACnet4J
10 stars 5 forks source link

Fix reset-local-device! always resetting every device #14

Closed WhittlesJr closed 6 years ago

WhittlesJr commented 6 years ago

Before this change, terminate! would get called with nil from reset-local-device!. So get-local-device would grab the first device it found instead of the intended one.

I found this when an MSTP device was getting reset by the creation of another (IP) device. The reset was not pretty and it threw an error down in the serial implementation.

That itself might also be a separate issue...

Frozenlock commented 6 years ago

Good catch, thanks!

WhittlesJr commented 6 years ago

Heh I probably never would have noticed had it not been for that serial error... Thanks for the quick merge!