Open Nytra opened 2 weeks ago
Also, has anyone looked into using reverse patches for the connectors instead of just copying their code 1:1 ?
Aren't reverse patches used when you still need to use the original unedited method? Otherwise you'd either prefix, postfix, transpile, or reimplement.
But yeah a lot of current bugs probably stem from the incomplete connector implementations. Some of them were not originally included because they weren't critical to implement, but we should aim for connector parity when possible.
Well I was thinking that most of the connectors in the mod are basically exact copies of the original connectors, wouldn't it be better to just call the original code in that case? Sorry if I'm not understanding something.
RenderTransformOverride connector needs updating, and also RenderContextOverride<T>
and RenderMaterialOverride connector need to be added
edit: added in https://github.com/Frozenreflex/Thundagun/pull/45
Skinned mesh renderer and mesh renderer base connectors updated in #48, fixing #8
LODGroup connector added
VideoTextureConnector added in https://github.com/Frozenreflex/Thundagun/pull/49
Known connectors with problems: AudioReverbZone, ~Particles~, ~desktop viewer~, ~material property blocks~, VisemeAnalyzer
Desktop viewer fixed in https://github.com/Frozenreflex/Thundagun/pull/57
Material property blocks will be fixed in https://github.com/Frozenreflex/Thundagun/pull/59
edit:
particles fixed in https://github.com/Frozenreflex/Thundagun/pull/60
I have found some connectors that are missing some things from the original code that cause it to not work e.g. https://github.com/Frozenreflex/Thundagun/pull/33 for camera portals
I think 3d textures are broken too due to stuff missing from texture connector which I am looking into
Edit: 3d textures fixed