Frozenreflex / Thundagun

Lightning fast performance mod for Resonite
GNU General Public License v3.0
6 stars 5 forks source link

Make sure all connectors match the original code #34

Open Nytra opened 2 weeks ago

Nytra commented 2 weeks ago

I have found some connectors that are missing some things from the original code that cause it to not work e.g. https://github.com/Frozenreflex/Thundagun/pull/33 for camera portals

I think 3d textures are broken too due to stuff missing from texture connector which I am looking into

Edit: 3d textures fixed

Nytra commented 2 weeks ago

Also, has anyone looked into using reverse patches for the connectors instead of just copying their code 1:1 ?

DoubleStyx commented 2 weeks ago

Aren't reverse patches used when you still need to use the original unedited method? Otherwise you'd either prefix, postfix, transpile, or reimplement.

DoubleStyx commented 2 weeks ago

But yeah a lot of current bugs probably stem from the incomplete connector implementations. Some of them were not originally included because they weren't critical to implement, but we should aim for connector parity when possible.

Nytra commented 2 weeks ago

Well I was thinking that most of the connectors in the mod are basically exact copies of the original connectors, wouldn't it be better to just call the original code in that case? Sorry if I'm not understanding something.

Nytra commented 2 weeks ago

RenderTransformOverride connector needs updating, and also RenderContextOverride<T> and RenderMaterialOverride connector need to be added

edit: added in https://github.com/Frozenreflex/Thundagun/pull/45

Nytra commented 2 weeks ago

Skinned mesh renderer and mesh renderer base connectors updated in #48, fixing #8

LODGroup connector added

Nytra commented 2 weeks ago

VideoTextureConnector added in https://github.com/Frozenreflex/Thundagun/pull/49

Known connectors with problems: AudioReverbZone, ~Particles~, ~desktop viewer~, ~material property blocks~, VisemeAnalyzer

Nytra commented 2 weeks ago

Desktop viewer fixed in https://github.com/Frozenreflex/Thundagun/pull/57

Material property blocks will be fixed in https://github.com/Frozenreflex/Thundagun/pull/59

edit:

particles fixed in https://github.com/Frozenreflex/Thundagun/pull/60