Frstrm / TokenLightCondition

Determine the lighting conditions of a token based on placed lights and token lights
MIT License
1 stars 4 forks source link

Effects not generated in PF2E #68

Closed liquidsonic closed 3 months ago

liquidsonic commented 3 months ago

Getting errors with grabbing flags it seems :(

liquidsonic commented 3 months ago

image

image

liquidsonic commented 3 months ago

on an added note, I commented out the flags just to see what happens

It seems it still doesn't know how to create the effect on the token. Just returns

actor cannot be undefined. So seems the method for grabbing that token from the HUD isn't grabbing

liquidsonic commented 3 months ago

On even further investigation, by creating the effects matching the specs in the code it seems to work as intended now.(Thank you for including some logging settings !)

Seems to be that it isnt creating the effects in the world which is getting skipped somehow so it its reference nothing

Frstrm commented 3 months ago

I'm not up to speed on all of the recent changes around affects myself at the moment, ( especially this core.statusId change. I'm interested in where you found the specs, or at your local changes to see an example of your change that works. ) I'm primarily in Maintenance mode with this module, since I'm not actively making more changes to it, since it met my needs at the time.

Frstrm commented 3 months ago

I have a fix for both the item effects being created if they don't exist ( pf2e ), and for the undefined flags error. Should be in the next update...