search

Frug / AJAX-Chat

A fully customizable web chat implemented in JavaScript, PHP and MySQL which integrates nicely with common forum systems like phpBB, MyBB, FluxBB, SMF and vBulletin. A Flash and Ruby based socket connection can be used to boost performance.
http://frug.github.io/AJAX-Chat/
545 stars 301 forks source link

Typing errors mo3 #293

Open wintstar opened 6 months ago

wintstar commented 6 months ago

https://github.com/Frug/AJAX-Chat/blob/731d7b12ad9ffb8db0b6af420514fcdccc238c69/public/js/chat.js#L663

This should be mp3 and not mo3?

var audio, mp3, ogg;

zwiebus commented 6 months ago

In terms of content yes, but there is a mo3 format : https://filext.com/de/dateiendung/MO3 ... So not sure if this could be meant

wintstar commented 6 months ago

It is a typing error. No .mo3 file will be used, look:

https://github.com/Frug/AJAX-Chat/tree/psr-4/public/sounds

It relates to the branch "psr-4" that is not yet official version 0.9.0.

I still have some errors / improvements. But I'm still thinking since this branch is not yet "master", to publish it with me or to create some Pull requests here.

zwiebus commented 6 months ago

I also use the psr-4 branch. The reason was of course that it runs near perfectly with php 8.2. However, i have already made some adjustments. So i have not found any other errors after that so far, at least none that limit the functionality. I also see no reason for merge solved issues cause its no master.