Frumph / comic-easel

Comic Easel is a plugin for WordPress that let's you have a WebComic with any WordPress theme.
http://comiceasel.com
21 stars 13 forks source link

According to GlotPress, CE is "not properly prepared for localization" (failed import) #23

Closed JN-Squire closed 6 years ago

JN-Squire commented 7 years ago

So I discovered GlotPress and figured it would be much easier to create and maintain localizations of the plugin with this tool (for now). But it displays the following error: image

The help page says "it usually means that something is wrong with the text domain" and talks about getting details through a Slack channel.

So in order to solve this bug, I suggest we get first the details of the failed import @Frumph : do you think you could do it? It would be really helpful.

Frumph commented 7 years ago

Does it say "why" it doesn't think it's not properly prepared for localization .. cause codestyle localization is loading it just fine

JN-Squire commented 7 years ago

Yes it does. I just figured how to find the info in the #meta-language-packs channel in the WlordPress Slack group. Here is the screenshot of what happened at the import: slack_2017-02-24_15-55-39

It looks like to needs a special kind of text domain declaration in the file header.

According to the Translations FAQ,

Please follow the instructions in the plugin developer handbook to internationalize all your strings, taking careful note to have a “Text Domain:” in your plugin header that matches the slug of your plugin.

So fixing this bug probably implies to change the "Text Domain" (currently "@ comiceasel" in MO and PO files if I got it right) in ComicEasel plugin header to "comic-easel"?

Frumph commented 7 years ago

Okay, will add.

JN-Squire commented 7 years ago

@Frumph There, I edited the files. Now we will only know if the requirements are meet once it gets imported in the WordPress repository. Edit: Since an update on WordPress.org seems needed in order to test the fix, I also updated the readme.txt file. Trying to be careful, I mentioned the GlotPress compatibility is experimental.

Frumph commented 6 years ago

added to github, seemed it didnt stick