search

Fruneau / pfixtools

The pfixtools project is a collection of postfix-related tools. The pfixtools are written in C.
Other
26 stars 7 forks source link

Socketmap postfix protocol so unix sockets can be used etc. #7

Closed driskell closed 10 years ago

driskell commented 10 years ago

Hi,

This adds the socketmap functionality so we can use unix sockets with postfix - which adds to security on shared hosting servers etc. It also implements those user/group changes from libcommon.

I have also done my best to update the documentation on the new options, and add the SRS check bits to postlicyd I'm currently using.

The RedHat init scripts I'm currently using I've also added, and quoted the source of them, and my modifications.

I've been running it for a couple weeks so it would also be good to hear if anyone else tries it and if it works OK :-)

Thanks,

Jason

driskell commented 10 years ago

I hope adding onto AUTHORS in Contributors wasn't too cheeky! :-) Thanks.

driskell commented 10 years ago

Thanks Fruneau, I'll work through all those once you've finished. I appreciate the time. The for() loop logic inside I think I've done that a few times - clearly hit a bad habit there, I'll get rid of every one. Again, thanks for the time.

Fruneau commented 10 years ago

Most of my comments are about the formatting of the code. This looks globally good.

No problem for adding yourself in the AUTHORS, I think you deserve it.

driskell commented 10 years ago

Thanks Fruneau, really appreciate the time, I'll work through everything and double-check it over and let you know when I'm done.

Again, thanks. I've enjoyed doing this :-)

driskell commented 10 years ago

Hi Fruneau,

I've gone through and fixed all the tabbing issues (fixed my editor config properly this time) and the readability and naming issues you've raised. I've also adjusted the doc files and configurations and made sure they take the view of TCP as the default configuration.

Let us know if there is anything else that you want me to look at.

Thanks!

driskell commented 10 years ago

Testing again as I spotted a couple libcommon things. Will let you know when done.

driskell commented 10 years ago

OK everything looks finished and it builds perfectly again, let me know if there is anything else.

I will also update in a week after running this on my servers but it looks good so far :-)

Thanks.

Fruneau commented 10 years ago

Nice job.