Fryyyyy / Fryatog

GoLang based IRC bot for looking up MTG Rules/Oracle
4 stars 3 forks source link

Make tests more impervious to changes #197

Open lunakv opened 1 year ago

lunakv commented 1 year ago

Right now, the tests are breaking (again) because a new subtype was added and it's not included in our test data. Given how often this tends to happen, it would be nice to figure out a way to set up the tests in a way that doesn't break them every set release.

Some ideas on possible approaches to this:

lunakv commented 5 months ago

(An example I stumbled upon just now that illustrates why this is relevant:) image

Fryyyyy commented 5 months ago

How about we just make the rule number a regex (\d+\.\d+ or something) and just make sure it work without caring specifically what number it ends up being