search

Frzk / ansible-role-chrony

Ansible role to manage chrony.
Apache License 2.0
14 stars 8 forks source link

Please do a release of your ansible-role-chrony #4

Closed gearboxscott closed 3 years ago

gearboxscott commented 3 years ago

Hi,

Nice ansible role, please do a release tag on it so the user can do a version in requirements.yml. It will help when you make changes and the user can decide to upgrade their code to your new patch or changes on a schedule, not just a thing that happens.

Thank You, GearBoxScott

Frzk commented 3 years ago

Hi @gearboxscott, Thanks for this. I'll definitely do it as soon as the tests are passing again. I need to invest some time in it. I'll let this open as a reminder and close it when it'll be done. Hopefully soon :)

Frzk commented 3 years ago

Fixed :) Thanks again for your interest !

srl295 commented 3 years ago

@Frzk hi- is https://github.com/Frzk/ansible-role-chrony/commit/a7dd46897834c87e5af8dcd5a2522ca1a510a076 no longer available via ansible galaxy?

Frzk commented 3 years ago

@srl295 : I’m afraid it’s not. Is there anything specific to this version that you’re missing with the current one ?

srl295 commented 3 years ago

@srl295 : I’m afraid it’s not. Is there anything specific to this version that you’re missing with the current one ?

Nothing specific, just broke my build when it wasn't available

srl295 commented 3 years ago

@srl295 : I’m afraid it’s not. Is there anything specific to this version that you’re missing with the current one ?

Nothing specific, just broke my build when it wasn't available

Looks like I can work around it with this:

-- name: frzk.chrony
-  version: a7dd46897834c87e5af8dcd5a2522ca1a510a076
+- src: https://github.com/frzk/ansible-role-chrony
+  version: a7dd46897834c87e5af8dcd5a2522ca1a510a076
+  name: frzk.chrony
Frzk commented 3 years ago

Nothing specific, just broke my build when it wasn't available

Oh, I'm sorry to read that :-/

For now on, I'll try to publish the changes in a development branch and merge them into main along with a new (tagged) release.

Would it work for you ?

srl295 commented 3 years ago

Nothing specific, just broke my build when it wasn't available

Oh, I'm sorry to read that :-/

For now on, I'll try to publish the changes in a development branch and merge them into main along with a new (tagged) release.

Would it work for you ?

sounds good. It was just the deleting of old items that was a challenge. In any event, the above workaround worked for me until I can try out your 1.0.0 !