search

FuYaoDe / react-native-app-intro

react-native-app-intro is a react native component implementing a parallax effect welcome page using base on react-native-swiper , similar to the one found in Google's app like Sheet, Drive, Docs...
MIT License
3.24k stars 508 forks source link

Changed from deprecated PropTypes to prop-types package to support React 16.0.0 #96

Open mckn opened 7 years ago

mckn commented 7 years ago

Hello,

I changed so this package have a dependency on the "prop-types" package instead of getting the PropTypes from React. It is deprecated since a while back and PropTypes is removed in the full version for React 16.

Please accept this PR. Thanks!

ghost commented 6 years ago

@mckn would you mind including in that PR a revert back to the original react-native-swiper instead of @FuYaoDe which is not being maintained and affected by the same PropTypes issue with React 16?

mlabrum commented 6 years ago

@FuYaoDe could we get this merged?

ghost commented 6 years ago

@mckn I still get an error using this patch, related to react-native-swiper, not you?

ScreamZ commented 6 years ago

Need this being merged... Thanks

kodamirmo commented 6 years ago

Any update? merge asap please

flybayer commented 6 years ago

I need this too.

ofirdagan commented 6 years ago

👍 - but this PR is not enough.. the react-native-swiper also needs to be upgraded. This fork doesn't work w/ the original react-native-swiper`

ghost commented 6 years ago

@ofirdagan I've sent an email to @FuYaoDe here to try to unlock the situation.

vuyani-k commented 6 years ago

MERGE PLZ

manishoo commented 6 years ago

MERGE PLEASE!

ghost commented 6 years ago

@jolinkomo-code @mehdijjz I haven't heard back from @FuYaoDe in my previous contact attempt.