FubarDevelopment / FtpServer

Portable FTP server written in .NET
http://fubardevelopment.github.io/FtpServer/
MIT License
472 stars 161 forks source link

Replace NGettext dependency #158

Closed ite-klass closed 8 months ago

ite-klass commented 8 months ago

The FTP protocol supports translation of response texts (while FTP commands and codes never change).

Support for text translations was implemented through ILocalizationFeature and the NGettext dependency and its ICatalog and Catalog types. The NGettext catalog attempts to load translation files - but by default fails as there are no translation files.

This changeset drops the NGettext dependency in favor of implementing our own interface. The interface surface is reduced by defining only the methods we use (GetString).

This is a breaking change. The impact is likely very low. Few people will have used or implemented custom translations. For those that did, a fixup is simple.

References:

ite-klass commented 8 months ago

Awesome, thank you! 🎉