FubarDevelopment / FtpServer

Portable FTP server written in .NET
http://fubardevelopment.github.io/FtpServer/
MIT License
478 stars 163 forks source link

Partial fix for #25 #26

Closed mvacha closed 5 years ago

mvacha commented 6 years ago

Fixes #25 for STOR command. PWD, CWD and other commands that modify the Data.Path stack without checking for (sub)folder existence are not covered.

I tried to fix the root cause instead of pathing the single STOR command (which is the problem for me), so I hope my fix doesn't break anything else.

It is an ugly hack, so I would appreciate any advice how to fix it in an elegant way.

fubar-coder commented 6 years ago

I'll try to come up with a good unit test.

fubar-coder commented 5 years ago

I'm not merging this PR, because trying to fix such things is an endless effort and usually not worth it. I'll just let the underlying OS/file system handle this problem.

Thank you for your PR.