FubarDevelopment / restsharp.portable

Some kind of a RestSharp port to PCL
BSD 2-Clause "Simplified" License
96 stars 33 forks source link

ensure that the correct httpclientfactory is used in restclientbase #81

Closed Yantrio closed 8 years ago

Yantrio commented 8 years ago

At the moment, if you set the HttpClientFactory property on RestClientBase, it uses the original property sent in by the constructor.

This PR will allow you to set the HttpClientFactory and then when the HttpClient is created, it will use the new one, and not the original from the ctor arg.

Yantrio commented 8 years ago

Thanks for merging, is there any chance I could get this pushed to myget please?

fubar-coder commented 8 years ago

Should be available any moment now.

jchannon commented 8 years ago

Is this the correct place to look? https://www.myget.org/feed/restsharp-portable/package/nuget/FubarCoder.RestSharp.Portable.Core

fubar-coder commented 8 years ago

Yes, that's the new package

jchannon commented 8 years ago

It's says last updated a month ago

On Friday, 12 August 2016, Mark Junker notifications@github.com wrote:

Yes, that's the new package

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FubarDevelopment/restsharp.portable/pull/81#issuecomment-239503626, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGaplv9P2XBRlBS_s2OAVZYJL9CqI17ks5qfKiVgaJpZM4JjGMf .

fubar-coder commented 8 years ago

A unit test failed (gateway time-out). I'll restart the build. I'll have to look at it when I'm home when the problem remains.

fubar-coder commented 8 years ago

Should be available now. All tests passed.

jchannon commented 8 years ago

Awesome. Thanks

On Saturday, 13 August 2016, Mark Junker notifications@github.com wrote:

Should be available now. All tests passed.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/FubarDevelopment/restsharp.portable/pull/81#issuecomment-239610109, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGapjHwra4VDLZB0Gtm3SRTy5lTStwbks5qfYJqgaJpZM4JjGMf .