FubuMvcArchive / bottles

OBSOLETE - Modular runtime packaging for .Net applications
http://fubuworld.com/bottles
Other
26 stars 16 forks source link

Use foreach instead of Extension method due to mono compiler bug. #95

Closed alistair closed 10 years ago

alistair commented 10 years ago

mono has a compiler bug which causes bottles to fail to compile. This fixes the issue by using foreach instead of the IEnumerable Each extension method.

Bag to track upstream is here. https://bugzilla.xamarin.com/show_bug.cgi?id=16513

jeremydmiller commented 10 years ago

Which version of Mono are you using? I thought they got the extension method problems fixed.

We struggled mightily w/ Mono and extension methods once upon a time.

On Nov 29, 2013, at 7:46 PM, Alistair notifications@github.com wrote:

mono has a compiler bug which causes bottles to fail to compile. This fixes the issue by using foreach instead of the IEnumerable Each extension method.

Bag to track upstream is here. https://bugzilla.xamarin.com/show_bug.cgi?id=16513

You can merge this Pull Request by running

git pull https://github.com/alistair/bottles mono_compile_error Or view, comment on, or merge it at:

https://github.com/DarthFubuMVC/bottles/pull/95

Commit Summary

Use foreach instead of Extension method due to mono compiler bug. File Changes

M src/Bottles/PackageFiles.cs (7) Patch Links:

https://github.com/DarthFubuMVC/bottles/pull/95.patch https://github.com/DarthFubuMVC/bottles/pull/95.diff

alistair commented 10 years ago

Basically master - a couple of days. It seems they missed one :) I tried to create a simpler reproduction but have so far failed (aka it compiled).

$ mono --version Mono Runtime Engine version 3.2.7 (branch-master/53cb3ab Fri Nov 29 22:19:59 NZDT 2013) Copyright (C) 2002-2013 Novell, Inc, Xamarin Inc and Contributors. www.mono-project.com TLS: __thread SIGSEGV: altstack Notifications: epoll Architecture: amd64 Disabled: none Misc: softdebug LLVM: supported, not enabled. GC: sgen