FubuMvcArchive / ripple

Super charged dependency management with Nuget without the merge hell
http://fubuworld.com/ripple
Other
45 stars 35 forks source link

Passing null nuget semantic version #161

Open NeerajR- opened 11 years ago

NeerajR- commented 11 years ago

ripple breaks when the version information is empty and a null semantic version is returned:

ripple/src/ripple/Model/Dependency.cs

return Version.IsNotEmpty() ? NuGet.SemanticVersion.Parse(Version) : null;

jmarnold commented 11 years ago

Can you give me some more context on where/how this happens?

On Wed, Aug 28, 2013 at 3:33 AM, NeerajR-SAHL notifications@github.comwrote:

ripple breaks when the version information is empty and a null semantic version is returned:

ripple/src/ripple/Model/Dependency.cs

return Version.IsNotEmpty() ? NuGet.SemanticVersion.Parse(Version) : null;

— Reply to this email directly or view it on GitHubhttps://github.com/DarthFubuMVC/ripple/issues/161 .

NeerajR- commented 11 years ago

It occurred when the version on the dependency was null and the version spec file contained the version in the dependency object. I don’t remember which nupkg file caused this but I am unable to replicate this.

From: Josh Arnold [mailto:notifications@github.com]

Sent: 28 August 2013 03:15 PM

To: DarthFubuMVC/ripple

Cc: Neeraj Ramautar

Subject: Re: [ripple] Passing null nuget semantic version (#161)

Can you give me some more context on where/how this happens?

T: | F: |C: E: NeerajR@sahomeloans.com

On Wed, Aug 28, 2013 at 3:33 AM, NeerajR-SAHL notifications@github.com<mailto:notifications@github.com>wrote:

ripple breaks when the version information is empty and a null semantic

version is returned:

ripple/src/ripple/Model/Dependency.cs

return Version.IsNotEmpty() ? NuGet.SemanticVersion.Parse(Version) : null;

Reply to this email directly or view it on GitHubhttps://github.com/DarthFubuMVC/ripple/issues/161

.

Reply to this email directly or view it on GitHubhttps://github.com/DarthFubuMVC/ripple/issues/161#issuecomment-23412722.