FubuMvcArchive / ripple

Super charged dependency management with Nuget without the merge hell
http://fubuworld.com/ripple
Other
45 stars 35 forks source link

Ripple renames the nugets when downloading #200

Closed andreasohlund closed 11 years ago

andreasohlund commented 11 years ago

We have a nuget called:

NServiceBus.4.1.0-Unstable7

and when ripple downloads it (and updates nuspecs) it gets renamed to:

NServiceBus.4.1.0.0-Unstable7

From the log:

Downloading http://builds.particular.net/guestAuth/repository/download/NServiceBusCore_Build/24278:id/NServiceBus.4.1.0-
Unstable7.nupkg to C:\Users\andreas.ohlund\AppData\Roaming\ripple\NServiceBus.4.1.0.0-Unstable7.nupkg

Is there a reason for this?

jmarnold commented 11 years ago

When we're dealing with the floating feeds, we parse the nuget information from the file name. In this case, it looks like:

Name: NServiceBus Version: 4.1.0-Unstable7

When we go to reconstruct the name, the version is an instance of SemanticVersion. So we're dealing with a canonical version vs. the raw string at that point. We could try to make it smarter so that it maintained the original name if it's a huge deal.

On Fri, Sep 20, 2013 at 6:39 AM, Andreas Öhlund notifications@github.comwrote:

We have a nuget called:

NServiceBus.4.1.0-Unstable7

and when ripple downloads it (and updates nuspecs) it gets renamed to:

NServiceBus.4.1.0.0-Unstable7

Downloading http://builds.particular.net/guestAuth/repository/download/NServiceBusCore_Build/24278:id/NServiceBus.4.1.0- Unstable7.nupkg to C:\Users\andreas.ohlund\AppData\Roaming\ripple\NServiceBus.4.1.0.0-Unstable7.nupkg

Is there a reason for this?

— Reply to this email directly or view it on GitHubhttps://github.com/DarthFubuMVC/ripple/issues/200 .

andreasohlund commented 11 years ago

No big deal I guess, just got confused!

What about the nuspec autoupdates?(will the original version be used there?)

Sent from my iPhone

On 20 sep 2013, at 15:25, Josh Arnold notifications@github.com wrote:

When we're dealing with the floating feeds, we parse the nuget information from the file name. In this case, it looks like:

Name: NServiceBus Version: 4.1.0-Unstable7

When we go to reconstruct the name, the version is an instance of SemanticVersion. So we're dealing with a canonical version vs. the raw string at that point. We could try to make it smarter so that it maintained the original name if it's a huge deal.

On Fri, Sep 20, 2013 at 6:39 AM, Andreas Öhlund notifications@github.comwrote:

We have a nuget called:

NServiceBus.4.1.0-Unstable7

and when ripple downloads it (and updates nuspecs) it gets renamed to:

NServiceBus.4.1.0.0-Unstable7

Downloading http://builds.particular.net/guestAuth/repository/download/NServiceBusCore_Build/24278:id/NServiceBus.4.1.0- Unstable7.nupkg to C:\Users\andreas.ohlund\AppData\Roaming\ripple\NServiceBus.4.1.0.0-Unstable7.nupkg

Is there a reason for this?

— Reply to this email directly or view it on GitHubhttps://github.com/DarthFubuMVC/ripple/issues/200 .

— Reply to this email directly or view it on GitHub.

jmarnold commented 11 years ago

The version may vary slightly but only due to a leading zero. Just depends on which token you use -- remember, we support NextMinor, NextMajor, Current. So you have control over the granularity of the version ranges.

On Fri, Sep 20, 2013 at 8:53 AM, Andreas Öhlund notifications@github.comwrote:

No big deal I guess, just got confused!

What about the nuspec autoupdates?(will the original version be used there?)

Sent from my iPhone

On 20 sep 2013, at 15:25, Josh Arnold notifications@github.com wrote:

When we're dealing with the floating feeds, we parse the nuget information from the file name. In this case, it looks like:

Name: NServiceBus Version: 4.1.0-Unstable7

When we go to reconstruct the name, the version is an instance of SemanticVersion. So we're dealing with a canonical version vs. the raw string at that point. We could try to make it smarter so that it maintained the original name if it's a huge deal.

On Fri, Sep 20, 2013 at 6:39 AM, Andreas Öhlund < notifications@github.com>wrote:

We have a nuget called:

NServiceBus.4.1.0-Unstable7

and when ripple downloads it (and updates nuspecs) it gets renamed to:

NServiceBus.4.1.0.0-Unstable7

Downloading http://builds.particular.net/guestAuth/repository/download/NServiceBusCore_Build/24278:id/NServiceBus.4.1.0- Unstable7.nupkg to C:\Users\andreas.ohlund\AppData\Roaming\ripple\NServiceBus.4.1.0.0-Unstable7.nupkg

Is there a reason for this?

— Reply to this email directly or view it on GitHub< https://github.com/DarthFubuMVC/ripple/issues/200> .

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/DarthFubuMVC/ripple/issues/200#issuecomment-24811669 .

andreasohlund commented 11 years ago

Cool'

Closes #200

Sent from my iPhone

On 20 sep 2013, at 16:00, Josh Arnold notifications@github.com wrote:

The version may vary slightly but only due to a leading zero. Just depends on which token you use -- remember, we support NextMinor, NextMajor, Current. So you have control over the granularity of the version ranges.

On Fri, Sep 20, 2013 at 8:53 AM, Andreas Öhlund notifications@github.comwrote:

No big deal I guess, just got confused!

What about the nuspec autoupdates?(will the original version be used there?)

Sent from my iPhone

On 20 sep 2013, at 15:25, Josh Arnold notifications@github.com wrote:

When we're dealing with the floating feeds, we parse the nuget information from the file name. In this case, it looks like:

Name: NServiceBus Version: 4.1.0-Unstable7

When we go to reconstruct the name, the version is an instance of SemanticVersion. So we're dealing with a canonical version vs. the raw string at that point. We could try to make it smarter so that it maintained the original name if it's a huge deal.

On Fri, Sep 20, 2013 at 6:39 AM, Andreas Öhlund < notifications@github.com>wrote:

We have a nuget called:

NServiceBus.4.1.0-Unstable7

and when ripple downloads it (and updates nuspecs) it gets renamed to:

NServiceBus.4.1.0.0-Unstable7

Downloading http://builds.particular.net/guestAuth/repository/download/NServiceBusCore_Build/24278:id/NServiceBus.4.1.0- Unstable7.nupkg to C:\Users\andreas.ohlund\AppData\Roaming\ripple\NServiceBus.4.1.0.0-Unstable7.nupkg

Is there a reason for this?

— Reply to this email directly or view it on GitHub< https://github.com/DarthFubuMVC/ripple/issues/200> .

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHubhttps://github.com/DarthFubuMVC/ripple/issues/200#issuecomment-24811669 .

— Reply to this email directly or view it on GitHub.