Ripple remove <nuget> -p <project> is modifying other projects

KevM commented 11 years ago

Using ripple-cli 2.3.3 an issuing this command

ripple remove Spark -p Agent.Core

I noticed in my changeset that my Web.csproj a completely different project is being modified. The worst part of this is that it is removing the <Private>True</Private> on some references which I put there to ensure these assemblies are not pulled from the GAC and ensure they are copied to the bin directory.

<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
   <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" />
   <PropertyGroup>
     <Configuration Condition=" '$(Configuration)' == '' ">Debug</Configuration>
     <Platform Condition=" '$(Platform)' == '' ">AnyCPU</Platform>
-    <ProductVersion>
-    </ProductVersion>
+    <ProductVersion></ProductVersion>
     <SchemaVersion>2.0</SchemaVersion>
     <ProjectGuid>{C68091A2-4A9E-4D6E-B0EA-BA5799C02DEF}</ProjectGuid>
     <ProjectTypeGuids>{349c5851-65df-11da-9384-00065b846f21};{fae04ec0-301f-11d3-bf4b-00c04f79efbc}</ProjectTypeGuids>
     <OutputType>Library</OutputType>
     <AppDesignerFolder>Properties</AppDesignerFolder>
     <RootNamespace>Web</RootNamespace>
     <AssemblyName>Web</AssemblyName>
     <TargetFrameworkVersion>v4.0</TargetFrameworkVersion>
     <UseIISExpress>true</UseIISExpress>
-    <FileUpgradeFlags>
-    </FileUpgradeFlags>
+    <FileUpgradeFlags></FileUpgradeFlags>
     <OldToolsVersion>4.0</OldToolsVersion>
-    <UpgradeBackupLocation>
-    </UpgradeBackupLocation>
+    <UpgradeBackupLocation></UpgradeBackupLocation>
     <IISExpressSSLPort />
     <IISExpressAnonymousAuthentication />
     <IISExpressWindowsAuthentication />
     <IISExpressUseClassicPipelineMode />
   </PropertyGroup>
@@ -58,27 +55,22 @@
     <Reference Include="Dovetail.Search.Client">
       <HintPath>..\..\nugets\Dovetail.Search.Client.dll</HintPath>
     </Reference>
     <Reference Include="FChoice.Common">
       <HintPath>..\packages\Dovetail.SDK\lib\net40\FChoice.Common.dll</HintPath>
-      <Private>True</Private>
     </Reference>
     <Reference Include="FChoice.Foundation.Clarify.Compatibility">
       <HintPath>..\packages\Dovetail.SDK\lib\net40\FChoice.Foundation.Clarify.Compatibility.dll</HintPath>
-      <Private>True</Private>
     </Reference>
     <Reference Include="FChoice.Foundation.Clarify.Compatibility.Toolkits">
       <HintPath>..\packages\Dovetail.SDK\lib\net40\FChoice.Foundation.Clarify.Compatibility.Toolkits.dll</HintPath>
-      <Private>True</Private>
     </Reference>
     <Reference Include="FChoice.Toolkits.Clarify">
       <HintPath>..\packages\Dovetail.SDK\lib\net40\FChoice.Toolkits.Clarify.dll</HintPath>
-      <Private>True</Private>
     </Reference>
     <Reference Include="fcSDK">
       <HintPath>..\packages\Dovetail.SDK\lib\net40\fcSDK.dll</HintPath>
-      <Private>True</Private>
     </Reference>
     <Reference Include="FubuCore">
       <HintPath>..\packages\FubuCore\lib\FubuCore.dll</HintPath>
     </Reference>
     <Reference Include="FubuLocalization">
@@ -135,11 +127,10 @@
     <Reference Include="HtmlTags">
       <HintPath>..\packages\HtmlTags\lib\4.0\HtmlTags.dll</HintPath>
     </Reference>
     <Reference Include="log4net">
       <HintPath>..\packages\log4net\lib\net40-full\log4net.dll</HintPath>
-      <Private>True</Private>
     </Reference>
     <Reference Include="Microsoft.CSharp" />
     <Reference Include="Microsoft.Web.Infrastructure, Version=1.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35, processorArchitecture=MSIL">
       <HintPath>..\packages\FubuMVC.1.0.0.121\lib\net40\Microsoft.Web.Infrastructure.dll</HintPath>
     </Reference>

jeremydmiller commented 11 years ago

I'm seeing this too. We're not being selective about the projects we touch for some reason.

smerrell commented 11 years ago

I just filed a similar bug (#235) for installing, so this probably is a thing for the other commands to be aware of too.

smerrell commented 10 years ago

And it looks like we got hit by the <Private>True</Private> removal issue as well.

FubuMvcArchive / ripple

Ripple remove <nuget> -p <project> is modifying other projects #219