Open agross opened 10 years ago
This one is actually a limitation in NuGet.Core - they're SemanticVersion class is not actually semver compliant, which has bitten us as well.
Michael
On 13 November 2013 12:36, Alexander Groß notifications@github.com wrote:
I'm currently trying ripple for a customer project with a couple (lots) of NuGet packages created by a team that is long gone. The TeamCity feed contains package IDs like this:
Foo.Bar.Service.2013.Obfuscated.0.0.0.890.nupkg
NugetName currently doesn't handle package IDs like this gracefully: It throws an exception because 2013.Obfuscated.0.0.0.890 is treated as the version number.
I can't change all package IDs like these now. I'm trying to, but it'll take time.
— Reply to this email directly or view it on GitHubhttps://github.com/DarthFubuMVC/ripple/issues/242 .
Oh the irony :)
On Wed, Nov 13, 2013 at 1:46 PM, Michael Newton notifications@github.comwrote:
This one is actually a limitation in NuGet.Core - they're SemanticVersion class is not actually semver compliant, which has bitten us as well.
Michael
On 13 November 2013 12:36, Alexander Groß notifications@github.com wrote:
I'm currently trying ripple for a customer project with a couple (lots) of NuGet packages created by a team that is long gone. The TeamCity feed contains package IDs like this:
Foo.Bar.Service.2013.Obfuscated.0.0.0.890.nupkg
NugetName currently doesn't handle package IDs like this gracefully: It throws an exception because 2013.Obfuscated.0.0.0.890 is treated as the version number.
I can't change all package IDs like these now. I'm trying to, but it'll take time.
— Reply to this email directly or view it on GitHub< https://github.com/DarthFubuMVC/ripple/issues/242> .
— Reply to this email directly or view it on GitHubhttps://github.com/DarthFubuMVC/ripple/issues/242#issuecomment-28391378 .
@mavnn There's a regex in ripple that rips apart the packagename.1.2.3.nupkg
and passes the extracted version number to NuGet.Core. I think this is the place where some smarts need to be added.
I'll add a failing test for this and try to get it worked out for 3.0. Thanks!
On Wed, Nov 13, 2013 at 6:49 AM, Andreas Öhlund notifications@github.comwrote:
Oh the irony :)
On Wed, Nov 13, 2013 at 1:46 PM, Michael Newton notifications@github.comwrote:
This one is actually a limitation in NuGet.Core - they're SemanticVersion class is not actually semver compliant, which has bitten us as well.
Michael
On 13 November 2013 12:36, Alexander Groß notifications@github.com wrote:
I'm currently trying ripple for a customer project with a couple (lots) of NuGet packages created by a team that is long gone. The TeamCity feed contains package IDs like this:
Foo.Bar.Service.2013.Obfuscated.0.0.0.890.nupkg
NugetName currently doesn't handle package IDs like this gracefully: It throws an exception because 2013.Obfuscated.0.0.0.890 is treated as the version number.
I can't change all package IDs like these now. I'm trying to, but it'll take time.
— Reply to this email directly or view it on GitHub< https://github.com/DarthFubuMVC/ripple/issues/242> .
— Reply to this email directly or view it on GitHub< https://github.com/DarthFubuMVC/ripple/issues/242#issuecomment-28391378> .
— Reply to this email directly or view it on GitHubhttps://github.com/DarthFubuMVC/ripple/issues/242#issuecomment-28391519 .
My fork already has the fix for 2.4. You should be able to see it on the issue page.
Alexander Groß Tiny phone, tiny mail On Nov 13, 2013 3:42 PM, "Josh Arnold" notifications@github.com wrote:
I'll add a failing test for this and try to get it worked out for 3.0. Thanks!
On Wed, Nov 13, 2013 at 6:49 AM, Andreas Öhlund notifications@github.comwrote:
Oh the irony :)
On Wed, Nov 13, 2013 at 1:46 PM, Michael Newton < notifications@github.com>wrote:
This one is actually a limitation in NuGet.Core - they're SemanticVersion class is not actually semver compliant, which has bitten us as well.
Michael
On 13 November 2013 12:36, Alexander Groß notifications@github.com wrote:
I'm currently trying ripple for a customer project with a couple (lots) of NuGet packages created by a team that is long gone. The TeamCity feed contains package IDs like this:
Foo.Bar.Service.2013.Obfuscated.0.0.0.890.nupkg
NugetName currently doesn't handle package IDs like this gracefully: It throws an exception because 2013.Obfuscated.0.0.0.890 is treated as the version number.
I can't change all package IDs like these now. I'm trying to, but it'll take time.
— Reply to this email directly or view it on GitHub< https://github.com/DarthFubuMVC/ripple/issues/242> .
— Reply to this email directly or view it on GitHub< https://github.com/DarthFubuMVC/ripple/issues/242#issuecomment-28391378>
.
— Reply to this email directly or view it on GitHub< https://github.com/DarthFubuMVC/ripple/issues/242#issuecomment-28391519> .
— Reply to this email directly or view it on GitHubhttps://github.com/DarthFubuMVC/ripple/issues/242#issuecomment-28399319 .
See it now, thanks!
I'm currently trying ripple for a customer project with a couple (lots) of NuGet packages created by a team that is long gone. The TeamCity feed contains package IDs like this:
NugetName currently doesn't handle package IDs like this gracefully: It throws an exception because
2013.Obfuscated.0.0.0.890
is treated as the version number.I can't change all package IDs like these now. I'm trying to, but it'll take time.