FubuMvcArchive / ripple

Super charged dependency management with Nuget without the merge hell
http://fubuworld.com/ripple
Other
45 stars 35 forks source link

Fixing problems with online feeds with 100+ packages + tests #274

Open ptrstpp950 opened 10 years ago

ptrstpp950 commented 10 years ago

The problem which I had was with nuget.org on which FloatingFeed.cs cannot find package by name. It was caused by wrongly method with downloading all packages from feed. The previous way was trying to use following query: /Packages()?$filter=IsLatestVersion&$orderby=DownloadCount%20desc,Id&$skip={0}&$top=100. But nuget.org returns only 40 packages even if top=100 is specified. I added test (named load_all_packages_from_feed_with_100plus_packages) which shows this problem.

Moreover I decided to optimize way of getting latest in findLatest method. Previously it was done by downloading all packages from feed and then query it for selected packages. Instead I deiced to query for specified packages, which doesn't need to download full feed.

Scooletz commented 10 years ago

:+1: