FubuMvcArchive / storyteller

OBSOLETE, see Storyteller2 -- DSL tool for .Net automated testing
Other
66 stars 13 forks source link

Added Retry knowledge for TeamCityListener #68

Closed GaryLCoxJr closed 12 years ago

GaryLCoxJr commented 12 years ago

We were getting a lot of false test fails on TeamCity since the listener wasn't aware of the retry concept. Basically the test would run, fail, and TC would be notified of a failed test. The retry would run, pass, and TC would be notified the test finished. TeamCity would display a failed run since it was told a test failed even though the test passed on the retry. Chad and I paired and came up with these changes to make the listener aware. So basically what happens the test runs, if it passes then it calls the MarkTestFinalStatus method which runs the code FinishTest used to perform for the listener. The listener was modified to ignore failed tests on FinishTest and to mark them as passed/failed on the MarkTestFinalStatus method which is called on the last run test. This will alleviate the false test fails on TeamCity. I'm not sure if this is right solution so I wanted to push a pull request for Jeremy to check out and either pull in or let me know a better way to handle this.