Fuchs / hoppla-sa

Linux / KDE Plasma desktop widget to control Philips Hue lights. Controls lights, groups and customizable actions.
https://store.kde.org/p/1168067/
GNU Lesser General Public License v2.1
65 stars 6 forks source link

Validate url to avoid trailing slash #5

Closed xf- closed 6 years ago

xf- commented 6 years ago

Editor strips trailing spaces - you can pick one line and close the PR. No editorconfig to override the setting.

Fuchs commented 6 years ago

As discussed on IRC:

this solution is tricky, because a validator in QML just doesn't let you type the characters with, by default, no feedback at all. This is not terribly user friendly, plus it makes cases like "allow no trailing slashes" hard to implement. This shall be fixed in the backend instead, by testing for trailing slashes and removing them there.