search

Fuco1 / smartparens

Minor mode for Emacs that deals with parens pairs and tries to be smart about it.
GNU General Public License v3.0
1.8k stars 193 forks source link

Support `ruby-ts-mode` #1162

Closed danielma closed 8 months ago

danielma commented 1 year ago

As of Emacs 29, ruby-mode and ruby-ts-mode are derived from ruby-base-mode. Have smartparens define behavior from the base mode to work with both

Fuco1 commented 1 year ago

This is a bit surprising but inheritance actually does not work everywhere in smartparens. I don't remember if this was a conscious decision (probably wasn't) and I think it should be fixed. But for now, your patch would not work.

Where it does work is pair configuration.

danielma commented 1 year ago

@Fuco1 Thank you for the feedback! That does surprise me, and it seemed to work correctly for me locally, but I've fixed it now.

It was very helpful of you to point out the specific places I needed to change

Fuco1 commented 8 months ago

Sorry for taking so long to merge this :blush: