search

Fuco1 / smartparens

Minor mode for Emacs that deals with parens pairs and tries to be smart about it.
GNU General Public License v3.0
1.8k stars 193 forks source link

Would you be open to a PR removing the anaphoric `dash` functions? #1172

Closed LemonBreezes closed 10 months ago

LemonBreezes commented 10 months ago

Hi. I've seen some benchmarks such as https://kisaragi-hiu.com/performance-cl-lib-dash-seq indicating that anaphoric versions of dash functionals such as --filter are much slower than their non-anaphoric counterparts like -filter. I am interested in going through the code and these replacements, as well as minor performance tweaks if any do come up. Would you be open to such a PR?

Fuco1 commented 10 months ago

When you install packages they are usually compiled so there shouldn't be any difference. In non compiled code it can be a bit slower.

I don't really mind such a change but maybe it's not really necessary.

LemonBreezes commented 10 months ago

When you install packages they are usually compiled so there shouldn't be any difference. In non compiled code it can be a bit slower.

I don't really mind such a change but maybe it's not really necessary.

Ohhh sorry. I read the benchmarks wrong. The anaphoric versions are the same speed for us since the functions they are called in are compiled.