search

Fuco1 / smartparens

Minor mode for Emacs that deals with parens pairs and tries to be smart about it.
GNU General Public License v3.0
1.8k stars 193 forks source link

Add support for clojure-ts-mode #1185

Closed kommen closed 4 days ago

kommen commented 5 months ago

clojure-ts-mode is developed as a distinct alternative to clojure-mode, as discussed here: https://github.com/clojure-emacs/clojure-mode/issues/640#issuecomment-1359708131

kommen commented 4 months ago

Marking as draft until this is resolved: https://github.com/clojure-emacs/clojure-ts-mode/pull/36

bbatsov commented 4 months ago

Hmm, do we even need to iterate the derived modes if there's no special smartparens configuration for them? Seems excessive to me. Perhaps the legacy config is from the days before all modes were folded in clojure-mode?

kommen commented 4 months ago

@bbatsov thanks for the feedback. I can give it a try in the next days without all the derived modes.

kommen commented 4 months ago

I removed all the derived modes. As far as I can tell, everything works fine in buffers using the derived modes.

kommen commented 2 months ago

@Fuco1 I have reverted the commit which removed the modes from the lists. Would you prefer me to force push it out?

Fuco1 commented 4 days ago

I rebased these commits to master and merged them separately. Sorry it took me so long. I will close this pull request but don't worry as the changes made it in.

Thanks!

kommen commented 4 days ago

@Fuco1 Thank you so much for your work and again for your feedback!