search

Fuco1 / sql-workbench

SQL client for Emacs
13 stars 2 forks source link

Some quickstart instructions. #16

Closed zck closed 6 years ago

Fuco1 commented 6 years ago

Thanks for the PR! Much appreciated. There are some minor things to address but then we can go ahead and merge :) I'll try to elaborate some more.

It's really motivating to see people come and do this work so thank you again :)

zck commented 6 years ago

I completed the incomplete sentence, added #'swb-show-data-in-table, and reworded #'swb-send-current-query so that all three high-level functions have their descriptions formatted the same (with the name and keybinding first, then the description).

I'm glad you're open to this; it was certainly better than having to write my own -- which was the alternate solution.

Fuco1 commented 6 years ago

@zck You wrote

Run M-x swb-connection-mysql. It will prompt for host, port, user, password, and the database inside the MySQL server to use.

I don't have such function. Did you write that yourself? If so it would be super cool to have it merged upstream! :D

I haven't even tried that because I always store the "credentials" in the workbench file (C-c C-s) and then it just reconnects automatically when I send the query for the first time).

zck commented 6 years ago

Ugh, you're right, that isn't a function. I was thinking of swb-new-mysql-workbench. Isn't that the right way to start the workbench?

If that's right, I fixed it in this PR: https://github.com/Fuco1/sql-workbench/pull/20. Sorry about that.

Also, what's the point of storing the credentials in the workbench? Is it to save the workbench as a file, then re-open it later? I don't seem to need to do that if I run swb-new-mysql-workbench, then do anything inside that workbench file.

Fuco1 commented 6 years ago

@zck I honestly don't ever remember writing that function :D

I always save the config in the file and then reopen it later and it knows where to connect. Usually in each of my projects I have a file mysql.swb (I associate swb with this mode) and when I want to do anything with the database I open that and I hve all my previous work + connection details so I literally just have to C-c C-c and type in the password. It's super convenient.