search

FuelLabs / cargo-toml-lint

A linter for Cargo.toml files
Apache License 2.0
6 stars 7 forks source link

Add Cargo.lock to .gitignore #11

Closed scouten closed 2 years ago

scouten commented 2 years ago

It's common, even recommended practice to include Cargo.lock in the git repo for binary crates. Quoting from the linked page:

... As a result, it is recommended that all binaries check in their Cargo.lock.

I'm assuming you've chosen not to do so for some intentional reason, but I'd like to not have the repo become dirty whenever I build the project, thus the request to add Cargo.lock to .gitignore.

(If you decide to instead add a Cargo.lock to the repo, then please close this PR without merging.)

adlerjohn commented 2 years ago

Now that you mention it; the artifact of this repo is a binary, so we probably should be including the lockfile!