FuelLabs / fuel-bridge

The canonical Fuel bridge mono repo.
https://app.fuel.network/portal/bridge
Apache License 2.0
173 stars 75 forks source link

Add zero address check for asset issuer ID in erc20 gateway v4 #250

Closed viraj124 closed 2 months ago

viraj124 commented 2 months ago
github-actions[bot] commented 2 months ago

This PR is published in NPM with version ****

DefiCake commented 2 months ago

Sorry I might have needed to be more explicit, but we need the check when doing deposits, not when configuring the value.

In fact, a zero value for the setter might be useful to disable deposits altogether

viraj124 commented 2 months ago

Sorry I might have needed to be more explicit, but we need the check when doing deposits, not when configuring the value.

In fact, a zero value for the setter might be useful to disable deposits altogether

I see I thought it's better to add the check in the setter tather than multiple deposit methods will update