FuelLabs / fuel-connectors

https://connectors.fuel.network
Apache License 2.0
65 stars 26 forks source link

Remove dependencies on `@fuel-ts/fuel-core` #84

Open petertonysmith94 opened 1 month ago

petertonysmith94 commented 1 month ago

As part of https://github.com/FuelLabs/fuels-ts/pull/2143. We have internalised @fuel-ts/fuel-core, therefore they won't be available via NPM once we release.

Note: this PR has not yet been merged and this is a pre-emptive measure to ensure we're not a blocker.

petertonysmith94 commented 1 month ago

Currently the following two files have dependency on @fuel-ts/account/test-utils which has a dependency on @fuel-ts/fuel-core:

These tests will need to run in the CI, so therefore, I am proposing we install fuelup and fuel-core in the pipeline. It would be good to get confirmation from @FuelLabs/frontend before making these changes, so have set at blocked for now.

helciofranco commented 1 month ago

@petertonysmith94 did you guys also moved to the pipeline in the SDK to handle cases like this? and regarding running locally, what are the needed changes?

petertonysmith94 commented 1 month ago

@helciofranco

did you guys also moved to the pipeline in the SDK to handle cases like this?

We have not, we've kept the binaries internally (see @internal/fuel-core), so we use these for our CI actions. However, it looks like we could use following action FuelLabs/action-fuel-toolchain to install the dependencies required for the CI.

regarding running locally, what are the needed changes?

With regards to running locally, it would involve using fuelup and managing the version of forc and fuel-core. Potentially a script to sync these with the current fuels version might be helpful?

petertonysmith94 commented 1 month ago

@helciofranco I've performed the upgrade to fuels@0.89.0 (which removes the forc and fuel-core dependencies).

Related PR: #89