fix(dnsaddr_resolution): use fqdn separator to prevent suffixing by dns resolvers

rymnc commented 1 month ago

Linked Issues/PRs

fixes https://github.com/FuelLabs/fuel-core/issues/2221

Description

Some dns resolvers nslookup etc, suffix dns lookups with the local domain if they are not fully-qualified. This PR makes the dns lookup FQDN, with a dot at the end.

Checklist

[x] Breaking changes are clearly marked as such in the PR description and changelog
[x] New behavior is reflected in tests
[ ] The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

[x] I have reviewed the code myself
[ ] I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

[Add or remove entries as needed]

[ ] Rust SDK
[ ] Sway compiler
[ ] Platform documentation (for out-of-organization contributors, the person merging the PR will do this)
[ ] Someone else?

Voxelot commented 1 month ago

is there a way we could make this test more self contained / work in an offline mode? It seems like depending on an external URL host could be fragile.

xgreenx commented 1 month ago

Test will fail in offline mode, but it is a small price to pay to verify that feature works properly=)

FuelLabs / fuel-core