search

FuelLabs / fuel-core

Rust full node implementation of the Fuel v2 protocol.
Other
58.15k stars 2.77k forks source link

Use bytes from `unrecorded_blocks` rather from the block from DA #2252

Open MitchTurner opened 4 days ago

MitchTurner commented 4 days ago

Linked Issues/PRs

Closes https://github.com/FuelLabs/fuel-core/issues/2244

Description

Essentially, we would be getting the compressed bytes from the committer, and we already have access to the true bytes in the unrecorded_blocks, so this PR changes the algo to use the values on those unrecorded_blocks

Uncovered some problems with the simulator in the mean time and created a followup issue for dealing with that.

image

Checklist

Before requesting review

Followup Issue

https://github.com/FuelLabs/fuel-core/issues/2264

MitchTurner commented 34 minutes ago

This could be a non-issue or a real deal that we might consider handling as an follow-up issue.

@rafal-ch It's possible that we get into a situation that this is never shrunk. I'm not sure what the correct way to handle it is. I don't think it should be the worry of the gas price algorithm though. If the committer isn't responding for days or weeks, then the issue is going to need to be addressed anyway. We can always modify the algorithm if we recognize a problem in production.