Closed MitchTurner closed 1 month ago
Notes from the huddle:
u128::MAX
limittotal_da_rewards_excess
can already happen when we're updating the L2 blocksAnyway, after analyzing the numbers, the conclusion is that we don't need the normalization function as the chances of the overflow are close to non-existent:
Hence, the way to go is to remove the normalization step.
cc: @MitchTurner
Closed with https://github.com/FuelLabs/fuel-core/pull/2293
Since adding the finalization period for the DA blocks in our gas price algorithm analyzer here https://github.com/FuelLabs/fuel-core/pull/2240 , the way our simulation tallies the
actual_cost
doesn't work anymore.The problem is with the
_normalize_rewards_and_costs
function, which regularly trims the rewards and costs in the algorithm to avoid overflow. This simulation doesn't work with that because now theactual_cost
is recorded much later now.We can either
u128
to something beefier