search

FuelLabs / fuel-core

Rust full node implementation of the Fuel v2 protocol.
Other
57.96k stars 2.79k forks source link

Migrate from `eventsource_client` in `fuel-core-client` #2283

Open Br1ght0ne opened 1 month ago

Br1ght0ne commented 1 month ago

eventsource_client is used by fuel-core-client to handle SSE (server-sent events). The crate is not maintained to a high enough standard, and there were cases missing functionality or wrongly implemented standards. I suggest moving to a crate like reqwest-eventsource, which uses reqwest under the hood. reqwest handles all the aforementioned cases correctly, so I expect a crate like this to perform better.

MitchTurner commented 3 weeks ago

This seems like something we should track, but its hard to know how to prioritize this before understand more deeply the risks of sticking with eventsource_client and the risks and costs and breaking changes with moving to reqwest-eventsource.

For now, I'm going to leave at low priority.