search

FuelLabs / fuel-explorer

https://app.fuel.network
Apache License 2.0
89 stars 87 forks source link

fix: preventing 0x predicates to being showed and persisted #482

Closed rodrigobranas closed 2 months ago

rodrigobranas commented 2 months ago

Screenshot 2024-09-09 at 11 30 30 Screenshot 2024-09-09 at 11 30 44 Screenshot 2024-09-09 at 11 30 20

arthurgeron commented 2 months ago

This PR overlaps with #458. Though imho adjusting directly in graphql resolve seems like a better solution.

rodrigobranas commented 2 months ago

I think E2E tests expected predicate tabs to always show, they probably need to be adjusted

actually there are different issues, I was indexing 0x predicates and this PR is preventing that for next blocks. For the existing blocks I'm just avoiding return 0x predicates as it's not valid and makes sense while I don't delete them from database.

About the E2E tests, I did not change the behavior of the frontend, just not returning when there is no predicate (considering 0x).

The tests were fixed in another PR.

rodrigobranas commented 2 months ago

This PR overlaps with #458. Though imho adjusting directly in graphql resolve seems like a better solution.

I think that does not make sense to handle that on the frontend, it needs to rely on the backend in order to know whether there is or there isn't predicate for the account